vmtester: do not crash if create_vm returns nullptr #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Apr 23, 2019
| @@ -16,6 +16,8 @@ evmc_create_fn create_fn; | |||
| std::unique_ptr<evmc_instance, evmc_destroy_fn> create_vm() | |||
| { | |||
| auto vm = create_fn(); | |||
| if (vm == nullptr) | |||
| return {nullptr, nullptr}; | |||
| return {vm, vm->destroy}; | |||
There was a problem hiding this comment.
vm->destroy derefs vm even if it is nullptr.
And there is a proper assertion we want to hit in this case: https://github.com/ethereum/evmc/blob/master/test/vmtester/vmtester.hpp#L21
Merged
chfast
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off #233.